zuston commented on code in PR #3617:
URL: https://github.com/apache/fluss/pull/3617#discussion_r3584302499


##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/source/FlinkSource.java:
##########
@@ -290,7 +290,8 @@ public SourceReader<OUT, SourceSplitBase> 
createReader(SourceReaderContext conte
 
         flussConf.set(

Review Comment:
   aha. this logic is the aligned with the previous impl. I think it's OK to 
share



##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/source/FlinkSource.java:
##########
@@ -290,7 +290,8 @@ public SourceReader<OUT, SourceSplitBase> 
createReader(SourceReaderContext conte
 
         flussConf.set(

Review Comment:
   aha. this logic is aligned with the previous impl. I think it's OK to share



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to