fhan688 commented on code in PR #3622:
URL: https://github.com/apache/fluss/pull/3622#discussion_r3548699070
##########
fluss-server/src/main/java/org/apache/fluss/server/DynamicServerConfig.java:
##########
@@ -110,6 +112,8 @@ class DynamicServerConfig {
void register(ServerReconfigurable serverReconfigurable) {
serverReconfigures.put(serverReconfigurable.getClass(),
serverReconfigurable);
+ serverReconfigurable.validate(currentConfig);
+ serverReconfigurable.reconfigure(currentConfig);
}
Review Comment:
Thanks for catching this. Fixed by serializing register() with the same
write lock used by dynamic config updates. The method now validates and applies
the current config before adding the reconfigurable to serverReconfigures, so a
failed registration will not leave a stale entry behind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
