fhan688 commented on code in PR #3622:
URL: https://github.com/apache/fluss/pull/3622#discussion_r3548702323
##########
fluss-server/src/test/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessorTest.java:
##########
@@ -2241,7 +2241,14 @@ private static void drainPendingNotifyTriggers(
private int countInProgressRebalanceTasks(TableBucket... buckets) {
int count = 0;
for (TableBucket tb : buckets) {
- if
(eventProcessor.getRebalanceManager().getRebalancePlanForBucket(tb) != null) {
+ RebalanceStatus status =
+ eventProcessor
+ .getRebalanceManager()
+ .listRebalanceProgress(null)
+ .progressForBucketMap()
+ .get(tb)
+ .status();
+ if (!RebalanceStatus.FINAL_STATUSES.contains(status)) {
count++;
}
Review Comment:
Good point. Fixed the test helper to handle both a null RebalanceProgress
and missing bucket progress entries. Missing progress is now treated as not in
progress instead of throwing an NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
