gyang94 commented on code in PR #3222:
URL: https://github.com/apache/fluss/pull/3222#discussion_r3551551504
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -1549,6 +1549,16 @@ public class ConfigOptions {
+ "we will retain a log before we will
delete old segments to free up "
+ "space. If set to -1, the log will not
be deleted.");
+ public static final ConfigOption<Duration> TABLE_LOG_SEGMENT_ROLL_MS =
+ key("table.log.segment.roll-ms")
Review Comment:
It is a duration type config, not good to name it with `ms`.
Maybe rename it with `roll-threshold` ,`roll-time`, or
`active-roll-threshold` ... etc?
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -1549,6 +1549,16 @@ public class ConfigOptions {
+ "we will retain a log before we will
delete old segments to free up "
+ "space. If set to -1, the log will not
be deleted.");
+ public static final ConfigOption<Duration> TABLE_LOG_SEGMENT_ROLL_MS =
+ key("table.log.segment.roll-ms")
+ .durationType()
+ .defaultValue(Duration.ofMillis(-1))
Review Comment:
We should make this config alterable (can be dynamically changed). Otherwise
existing tables will always be -1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
