zuston commented on code in PR #3222:
URL: https://github.com/apache/fluss/pull/3222#discussion_r3585032473
##########
fluss-server/src/main/java/org/apache/fluss/server/log/remote/LogTieringTask.java:
##########
@@ -127,14 +127,15 @@ private void runOnce() throws InterruptedException {
TableMetricGroup metricGroup = replica.tableMetrics();
maybeUpdateCopiedOffset(logTablet);
+ logTablet.rollActiveSegmentIfExpired(currentTimeMs);
Review Comment:
Thanks for pointing out this potential issue, @swuferhong.
In Kafka’s tiered storage implementation, overlapping segment ranges are
handled at the remote metadata layer using leader epochs.
https://github.com/apache/kafka/blob/trunk/storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java#L902
For Fluss, I’m also exploring an alternative approach: propagating
roll-boundary markers from the leader to followers so that replicas maintain
consistent segment boundaries.
What do you think of this approach, @swuferhong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
