luoyuxia commented on code in PR #3569:
URL: https://github.com/apache/fluss/pull/3569#discussion_r3607721532
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/source/TieringSource.java:
##########
@@ -117,7 +118,11 @@ public SourceReader<TableBucketWriteResult<WriteResult>,
TieringSplit> createRea
getClientScannerIoTmpDir(flussConf,
sourceReaderContext.getConfiguration()));
Connection connection = ConnectionFactory.createConnection(flussConf);
return new TieringSourceReader<>(
- elementsQueue, sourceReaderContext, connection,
lakeTieringFactory);
+ elementsQueue,
+ sourceReaderContext,
+ connection,
+ lakeTieringFactory,
+ getLakeTieringIoTmpDir(flussConf,
sourceReaderContext.getConfiguration()));
Review Comment:
Could we pass or read this option from `lakeTieringConfig` instead?
`FlussLakeTiering` puts CLI keys starting with `lake.tiering.` into
`lakeTieringConfig`, while `flussConf` only contains `--fluss.*` keys after
removing the `fluss.` prefix. `LakeTieringJobBuilder` currently passes only
`flussConfig` to `TieringSource`, so a standard `--lake.tiering.io.tmpdir
/data/tmp` argument is absent here and always falls back to the Flink/JVM
temporary directory. Please wire `lakeTieringConfig` (or the resolved option)
into the source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
