luoyuxia commented on code in PR #3569:
URL: https://github.com/apache/fluss/pull/3569#discussion_r3607744786
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/source/TieringSourceReader.java:
##########
@@ -61,7 +63,23 @@ public TieringSourceReader(
SourceReaderContext context,
Connection connection,
LakeTieringFactory<WriteResult, ?> lakeTieringFactory) {
- this(elementsQueue, context, connection, lakeTieringFactory,
DEFAULT_POLL_TIMEOUT);
+ this(elementsQueue, context, connection, lakeTieringFactory, (String)
null);
+ }
+
+ public TieringSourceReader(
+
FutureCompletingBlockingQueue<RecordsWithSplitIds<TableBucketWriteResult<WriteResult>>>
+ elementsQueue,
+ SourceReaderContext context,
+ Connection connection,
+ LakeTieringFactory<WriteResult, ?> lakeTieringFactory,
+ @Nullable String ioTmpDir) {
Review Comment:
When it'll be null? Can we remove Nullable notation?
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/source/TieringSourceReader.java:
##########
Review Comment:
public TieringSourceReader(
FutureCompletingBlockingQueue<RecordsWithSplitIds<TableBucketWriteResult<WriteResult>>>
elementsQueue,
SourceReaderContext context,
Connection connection,
LakeTieringFactory<WriteResult, ?> lakeTieringFactory) {
this(elementsQueue, context, connection, lakeTieringFactory,
(String) null);
}
is not called anymore, seems can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
