Mukvin commented on code in PR #674:
URL: https://github.com/apache/geaflow/pull/674#discussion_r2533039657
##########
geaflow-console/app/core/service/src/main/java/org/apache/geaflow/console/core/service/llm/LocalClient.java:
##########
@@ -35,14 +35,14 @@ public class LocalClient extends LLMClient {
private static final String DEFAULT_N_PREDICT = "128";
- private static final String TEMPLATE = "{"
+ private static final String JSON_REQUEST_TEMPLATE = "{"
Review Comment:
fixed, please help me to review again.
##########
geaflow-console/app/core/service/src/main/java/org/apache/geaflow/console/core/service/llm/LocalClient.java:
##########
@@ -35,14 +35,14 @@ public class LocalClient extends LLMClient {
private static final String DEFAULT_N_PREDICT = "128";
- private static final String TEMPLATE = "{"
+ private static final String JSON_REQUEST_TEMPLATE = "{"
+ "\"prompt\": \"%s\","
+ "\"n_predict\": %s}";
private String getJsonString(LocalConfigArgsClass llm, String prompt) {
Integer predict = llm.getPredict();
// trim() to replace the last \n
- return String.format(TEMPLATE, prompt.trim(), predict);
Review Comment:
fixed, please help me to review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
