qingwen220 commented on code in PR #674:
URL: https://github.com/apache/geaflow/pull/674#discussion_r2533708084
##########
geaflow/geaflow-core/geaflow-engine/geaflow-cluster/src/main/java/org/apache/geaflow/cluster/constants/ClusterConstants.java:
##########
@@ -19,11 +19,14 @@
package org.apache.geaflow.cluster.constants;
+import org.apache.geaflow.common.config.Configuration;
+import org.apache.geaflow.common.config.keys.ExecutionConfigKeys;
+
public class ClusterConstants {
- private static final String MASTER_PREFIX = "master-";
- private static final String DRIVER_PREFIX = "driver-";
- private static final String CONTAINER_PREFIX = "container-";
+ public static final String MASTER_PREFIX = "master-";
+ public static final String DRIVER_PREFIX = "driver-";
+ public static final String CONTAINER_PREFIX = "container-";
Review Comment:
Why should we change these to public ?
##########
geaflow/geaflow-common/src/main/java/org/apache/geaflow/common/config/keys/ExecutionConfigKeys.java:
##########
@@ -638,4 +638,38 @@ public class ExecutionConfigKeys implements Serializable {
.defaultValue(false)
.description("if enable detail job metric");
+ // ------------------------------------------------------------------------
+ // cluster constants
+ // ------------------------------------------------------------------------
+
+ public static final ConfigKey CLUSTER_DRIVER_PREFIX = ConfigKeys
+ .key("geaflow.cluster.driver.prefix")
+ .defaultValue("driver-")
+ .description("driver name prefix");
+
+ public static final ConfigKey CLUSTER_CONTAINER_PREFIX = ConfigKeys
+ .key("geaflow.cluster.container.prefix")
+ .defaultValue("container-")
+ .description("container name prefix");
+
+ public static final ConfigKey CLUSTER_MASTER_LOG_SUFFIX = ConfigKeys
+ .key("geaflow.cluster.master.log.suffix")
+ .defaultValue("master.log")
+ .description("master log file suffix");
+
+ public static final ConfigKey CLUSTER_DRIVER_LOG_SUFFIX = ConfigKeys
+ .key("geaflow.cluster.driver.log.suffix")
+ .defaultValue("driver.log")
+ .description("driver log file suffix");
+
+ public static final ConfigKey CLUSTER_CONTAINER_LOG_SUFFIX = ConfigKeys
+ .key("geaflow.cluster.container.log.suffix")
+ .defaultValue("container.log")
+ .description("container log file suffix");
+
+ public static final ConfigKey CLUSTER_DEFAULT_MASTER_ID = ConfigKeys
+ .key("geaflow.cluster.default.master.id")
+ .defaultValue(0)
+ .description("default master id");
Review Comment:
All of these changes in the class are unnecessary. They are all for internal
use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
