[
https://issues.apache.org/jira/browse/GEODE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057815#comment-16057815
]
ASF GitHub Bot commented on GEODE-3075:
---------------------------------------
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/586
There was a failure in one of the new tests
:geode-core:integrationTest
org.apache.geode.internal.cache.tier.sockets.ServerConnectionFactoryIntegrationTest
> testNewProtocolHeaderLeadsToNewProtocolServerConnection FAILED
org.apache.geode.GemFireConfigException: The locators attribute can not
be empty when the mcast-port attribute is non-zero.
at
org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:603)
at
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:350)
at
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:338)
at
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:330)
at
org.apache.geode.distributed.DistributedSystem.connect(DistributedSystem.java:205)
at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:217)
at
org.apache.geode.internal.cache.tier.sockets.ServerConnectionFactoryIntegrationTest.testNewProtocolHeaderLeadsToNewProtocolServerConnection(ServerConnectionFactoryIntegrationTest.java:50)
> Bifurcate ServerConnection, create factory and feature toggle
> -------------------------------------------------------------
>
> Key: GEODE-3075
> URL: https://issues.apache.org/jira/browse/GEODE-3075
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Galen O'Sullivan
>
> Make a factory that creates instances of the new subclasses of
> {{ServerConnection}} : {{NewClientServerConnection}} and
> {{LegacyServerConnection}}. This will be the basis for future refactors. This
> should involve minimal changes to {{AcceptorImpl}} and a minimal
> implementation of {{NewClientServerConnection}}. All the existing
> functionality of {{ServerConnection}} must still work.
> To do this, we will need a feature toggle so that the new client protocol
> (which will now be in a broken state) never gets run in production, but can
> be enabled for testing. This should probably be set via a hidden system
> property and not through any config that is a part of the public API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
