[
https://issues.apache.org/jira/browse/GEODE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063351#comment-16063351
]
ASF subversion and git services commented on GEODE-3075:
--------------------------------------------------------
Commit c71c28dff7fd6d20798fadcbd6a1a15f055ae52e in geode's branch
refs/heads/develop from [~gosullivan]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c71c28d ]
GEODE-3075: changes in response to feedback; refactor some.
`AcceptorImpl.handleNewClientConnection` has had refactoring and should
be a bit more understandable.
> Bifurcate ServerConnection, create factory and feature toggle
> -------------------------------------------------------------
>
> Key: GEODE-3075
> URL: https://issues.apache.org/jira/browse/GEODE-3075
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Galen O'Sullivan
>
> Make a factory that creates instances of the new subclasses of
> {{ServerConnection}} : {{NewClientServerConnection}} and
> {{LegacyServerConnection}}. This will be the basis for future refactors. This
> should involve minimal changes to {{AcceptorImpl}} and a minimal
> implementation of {{NewClientServerConnection}}. All the existing
> functionality of {{ServerConnection}} must still work.
> To do this, we will need a feature toggle so that the new client protocol
> (which will now be in a broken state) never gets run in production, but can
> be enabled for testing. This should probably be set via a hidden system
> property and not through any config that is a part of the public API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
