[
https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095734#comment-16095734
]
ASF GitHub Bot commented on GEODE-3213:
---------------------------------------
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128678905
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
---
@@ -144,21 +138,22 @@ public void
processReturnsErrorWhenUnableToDecodeRequest()
when(serializationServiceStub.decode(BasicTypes.EncodingType.STRING,
TEST_KEY.getBytes(Charset.forName("UTF-8")))).thenThrow(exception);
- ClientProtocol.Request getRequest = generateTestRequest(false, false,
false);
- ClientProtocol.Response response = (ClientProtocol.Response)
operationHandler
--- End diff --
👍 getting rid of typecasts.
> Refactor Protobuf Serialization Implemenation
> ---------------------------------------------
>
> Key: GEODE-3213
> URL: https://issues.apache.org/jira/browse/GEODE-3213
> Project: Geode
> Issue Type: Improvement
> Components: client/server, serialization
> Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we
> want to make:
> * OperationHandlers take OperationRequest and OperationResponse message, not
> the parent Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow.
> No bespoke flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract
> OperationRequest from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate
> OperationResponse in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error
> codes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
