[
https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096981#comment-16096981
]
ASF GitHub Bot commented on GEODE-3213:
---------------------------------------
Github user PurelyApplied commented on the issue:
https://github.com/apache/geode/pull/646
If you are using IntelliJ as your IDE, please remember to update your style
file to that located in `geode/etc/intellij-java-modified-google-style.xml` to
be consistent with Geode's established style guide. This file was updated June
13 with commit `a561bd12` to be consistent with documented expectations. If
you are using Eclipse, please import both style guidefiles, also located in
`geode/etc/`.
After having done so, please optimize the imports to the correct order and
to eliminate the use of the wildcard imports from the 25 offending files this
pull request touches.
> Refactor Protobuf Serialization Implemenation
> ---------------------------------------------
>
> Key: GEODE-3213
> URL: https://issues.apache.org/jira/browse/GEODE-3213
> Project: Geode
> Issue Type: Improvement
> Components: client/server, serialization
> Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we
> want to make:
> * OperationHandlers take OperationRequest and OperationResponse message, not
> the parent Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow.
> No bespoke flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract
> OperationRequest from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate
> OperationResponse in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error
> codes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
