[
https://issues.apache.org/jira/browse/GEODE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102029#comment-16102029
]
ASF GitHub Bot commented on GEODE-3192:
---------------------------------------
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/643#discussion_r129649690
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
---
@@ -53,10 +52,10 @@
ProtobufUtilities.createEncodedValue(serializationService,
resultValue);
return
Success.of(RegionAPI.GetResponse.newBuilder().setResult(encodedValue).build());
} catch (UnsupportedEncodingTypeException ex) {
- return Failure.of(
- ClientProtocol.ErrorResponse.newBuilder().setMessage("Encoding
not supported.").build());
+ return Failure
--- End diff --
We're not entirely consistent with when we log errors and when we don't.
Probably these should be logged like the others?
> PutAll on new protocol informs client which keys couldn't be inserted
> ---------------------------------------------------------------------
>
> Key: GEODE-3192
> URL: https://issues.apache.org/jira/browse/GEODE-3192
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Alexander Murmann
>
> When a putAll request fails to insert a given key/value pair the
> corresponding response will contain information about which keys/values
> failed to be inserted.
> *Note:* We left this out of GEODE-2997 which initially introduces putAll
> because we want to get something to test with early.
> *Implementation Note:* The new protocol uses Region#putAll which returns
> void, but the old protocol uses basicBridgePutAll, which we don't understand
> but which seems to give more information. Having a look at the old protocol's
> putAll command could be useful.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
