[
https://issues.apache.org/jira/browse/GEODE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110254#comment-16110254
]
ASF GitHub Bot commented on GEODE-3319:
---------------------------------------
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/661#discussion_r130779627
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
---
@@ -50,10 +50,7 @@
return Success.of(RegionAPI.PutResponse.newBuilder().build());
} catch (ClassCastException ex) {
return Failure.of(BasicTypes.ErrorResponse.newBuilder()
- .setMessage("invalid key or value type for region " +
regionName + ",passed key: "
--- End diff --
I'm curious why you chose to shrink the message here; what am I missing?
> Use protobuf serialization for primitive types
> ----------------------------------------------
>
> Key: GEODE-3319
> URL: https://issues.apache.org/jira/browse/GEODE-3319
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Brian Baynes
>
> As a developer using the new protocol to write a new client, I'd rather not
> worry about binary encoding or endianness of primitives.
> Use protobuf for serialization of primitive types, which will take some
> burden off of the client and eliminate the problem of language-to-language
> endian mismatches.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
