[ https://issues.apache.org/jira/browse/GEODE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110251#comment-16110251 ]
ASF GitHub Bot commented on GEODE-3319: --------------------------------------- Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/661#discussion_r130494367 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.protocol.protobuf.utilities; + +import org.apache.geode.protocol.protobuf.utilities.exception.UnknownProtobufPrimitiveType; + +public enum ProtobufPrimitiveTypes { --- End diff -- I think it's better to use the singular `ProtobufPrimitiveType` here, since each represents a protobuf primitive type. > Use protobuf serialization for primitive types > ---------------------------------------------- > > Key: GEODE-3319 > URL: https://issues.apache.org/jira/browse/GEODE-3319 > Project: Geode > Issue Type: Improvement > Components: client/server > Reporter: Brian Baynes > > As a developer using the new protocol to write a new client, I'd rather not > worry about binary encoding or endianness of primitives. > Use protobuf for serialization of primitive types, which will take some > burden off of the client and eliminate the problem of language-to-language > endian mismatches. -- This message was sent by Atlassian JIRA (v6.4.14#64029)