[ 
https://issues.apache.org/jira/browse/GEODE-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113659#comment-16113659
 ] 

ASF GitHub Bot commented on GEODE-3314:
---------------------------------------

GitHub user galen-pivotal opened a pull request:

    https://github.com/apache/geode/pull/683

    GEODE-3314 - additional refactoring for developer QoL.

    * Write characterization tests for DLockService.
    * Remove debugging code.
    * Remove dead code.
    * Remove comments.
    * Extract the local lock granting into a separate function.
    
    Between the characterization tests we've written and the existing DUnit
    tests, the coverage should be fairly adequate.
    
    Signed-off-by: Hitesh Khamesra <hkames...@pivotal.io>
    Signed-off-by: Galen O'Sullivan <gosulli...@pivotal.io>
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [x] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
    submit an update to your PR as soon as possible. If you need help, please 
send an
    email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/galen-pivotal/geode feature/GEODE-3314-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #683
    
----
commit 6ec19370da30004347b20c22563268f6adfd35c1
Author: Galen O'Sullivan <gosulli...@pivotal.io>
Date:   2017-08-02T18:29:21Z

    GEODE-3314 - additional refactoring for developer QoL.
    
    * Write characterization tests for DLockService.
    * Remove debugging code.
    * Remove dead code.
    * Remove comments.
    * Extract the local lock granting into a separate function.
    
    Between the characterization tests we've written and the existing DUnit
    tests, the coverage should be fairly adequate.
    
    Signed-off-by: Hitesh Khamesra <hkames...@pivotal.io>
    Signed-off-by: Galen O'Sullivan <gosulli...@pivotal.io>

----


> OldGen heap usage grows without increase in data size, large number of 
> DLockTokens
> ----------------------------------------------------------------------------------
>
>                 Key: GEODE-3314
>                 URL: https://issues.apache.org/jira/browse/GEODE-3314
>             Project: Geode
>          Issue Type: Bug
>          Components: distributed lock service
>            Reporter: Udo Kohlmeyer
>            Assignee: Galen O'Sullivan
>             Fix For: 1.2.1
>
>
> When using Global Replicate regions, the DLockTokens are not correctly 
> cleaned up, causing a memory leak.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to