[
https://issues.apache.org/jira/browse/GEODE-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113726#comment-16113726
]
ASF GitHub Bot commented on GEODE-3314:
---------------------------------------
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131287366
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRequestProcessor.java
---
@@ -196,6 +196,13 @@ long getLeaseExpireTime() {
return this.response.leaseExpireTime;
}
+ /**
+ *
+ * @param interruptible
+ * @param lockId
+ * @return
+ * @throws InterruptedException only possible if interruptible is true.
+ */
protected boolean requestLock(boolean interruptible, int lockId) throws
InterruptedException {
final boolean isDebugEnabled_DLS =
logger.isTraceEnabled(LogMarker.DLS);
--- End diff --
Did you want to remove this, as you seem to be removing a lot of switching
based on it. Is this code going to be log spammy without this?
> OldGen heap usage grows without increase in data size, large number of
> DLockTokens
> ----------------------------------------------------------------------------------
>
> Key: GEODE-3314
> URL: https://issues.apache.org/jira/browse/GEODE-3314
> Project: Geode
> Issue Type: Bug
> Components: distributed lock service
> Reporter: Udo Kohlmeyer
> Assignee: Galen O'Sullivan
> Fix For: 1.2.1
>
>
> When using Global Replicate regions, the DLockTokens are not correctly
> cleaned up, causing a memory leak.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
