[
https://issues.apache.org/jira/browse/GEODE-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114959#comment-16114959
]
ASF GitHub Bot commented on GEODE-3258:
---------------------------------------
Github user pdxrunner commented on the issue:
https://github.com/apache/geode/pull/687
With regards to your comments on the test classes and possible duplication:
I would consider splitting the existing test classes so that each of the
new *Command classes has it's own tests. This may actually mean creating two
test classes for each command - a Unit test to cover the functionality that
doesn't need the overhead of the DUnit framework, and a DUnit test to cover
what can't be accomplished in the Unit test.
I would also consider making this refactoring incrementally, with separate
pull requests for each command that is extracted from the original
DiskStoreCommands class. The incremtnal PR's would then entail creating a
Command class and test classes as needed. As a starter, you may want to create
the ...Utils class when you first extract a command that needs the methods.
> Refactor DiskStoreCommands
> --------------------------
>
> Key: GEODE-3258
> URL: https://issues.apache.org/jira/browse/GEODE-3258
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{DiskStoreCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
