[
https://issues.apache.org/jira/browse/GEODE-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116881#comment-16116881
]
ASF GitHub Bot commented on GEODE-3258:
---------------------------------------
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/687
@pdxrunner The tests that cover these commands are part of a separate JIRA
ticket ([GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359)), so
@jinmeiliao recommended just refactoring the commands and leaving the tests to
be refactored in the future. I think I will try to add tests to cover the rest
of the commands to `DiskStoreCommandsJUnitTest`, since there are very few
commands covered by that test, but I think I'll leave
`DiskStoreCommandsDUnitTest` and `ListAndDescribeDiskStoreCommandsDUnitTest `
alone for now. What do you think?
> Refactor DiskStoreCommands
> --------------------------
>
> Key: GEODE-3258
> URL: https://issues.apache.org/jira/browse/GEODE-3258
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{DiskStoreCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
