[
https://issues.apache.org/jira/browse/GEODE-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117140#comment-16117140
]
ASF GitHub Bot commented on GEODE-3262:
---------------------------------------
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/690
GEODE-3262: Refactoring IndexCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3262)
`IndexCommands` was a huge class that contained a large number of commands.
These commands have been split into their own individual command classes.
`IndexCommandsDUnitTest` was also refactored to `ListIndexCommandDUnitTest`
because it was only testing `ListIndexCommand`... In the future, more tests
should be written to cover the other commands that were in `IndexCommands`.
**TESTING STATUS: Precheckin in progress**
- [x] JIRA ticket referenced
- [x] PR rebased
- [x] Initial commit is single and squashed
- [x] `gradlew build` runs cleanly
- [ ] Unit tests will be updated with
[GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359))
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3262
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #690
----
commit 34a2cc1f0b18309078c26abfd3bbf12d6c26423f
Author: YehEmily <[email protected]>
Date: 2017-08-07T19:35:14Z
GEODE-3262: Refactoring IndexCommands
----
> Refactor IndexCommands
> ----------------------
>
> Key: GEODE-3262
> URL: https://issues.apache.org/jira/browse/GEODE-3262
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{IndexCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
