[
https://issues.apache.org/jira/browse/GEODE-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117567#comment-16117567
]
ASF GitHub Bot commented on GEODE-3262:
---------------------------------------
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/690#discussion_r131790263
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateIndexCommand.java
---
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.concurrent.atomic.AtomicReference;
+
+import org.springframework.shell.core.annotation.CliCommand;
+import org.springframework.shell.core.annotation.CliOption;
+
+import org.apache.geode.cache.Cache;
--- End diff --
My eternal nitpicking: This import appears to be unused.
> Refactor IndexCommands
> ----------------------
>
> Key: GEODE-3262
> URL: https://issues.apache.org/jira/browse/GEODE-3262
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{IndexCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
