[
https://issues.apache.org/jira/browse/GEODE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117166#comment-16117166
]
ASF GitHub Bot commented on GEODE-3260:
---------------------------------------
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/691
GEODE-3260: Refactoring FunctionCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3260)
`FunctionCommands` was a huge class that contained a large number of
commands. These commands have been split into their own individual command
classes.
**TESTING STATUS: Precheckin in progress**
- [x] JIRA ticket referenced
- [x] PR rebased
- [x] Initial commit is single and squashed
- [x] `gradlew build` runs cleanly
- [ ] Unit tests will be updated with
[GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359))
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3260
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/691.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #691
----
commit 0265b29cc104e0b166dc5972bf739f042276cb5b
Author: YehEmily <[email protected]>
Date: 2017-08-07T19:56:17Z
GEODE-3260: Refactoring FunctionCommands
----
> Refactor FunctionCommands
> -------------------------
>
> Key: GEODE-3260
> URL: https://issues.apache.org/jira/browse/GEODE-3260
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{FunctionCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
