[
https://issues.apache.org/jira/browse/GEODE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117552#comment-16117552
]
ASF GitHub Bot commented on GEODE-3260:
---------------------------------------
Github user PurelyApplied commented on the issue:
https://github.com/apache/geode/pull/691
+1.
A far-from-critical nitpick: there are several places in
`ExecuteFunctionCommand` and one in `DestroyFunctionCommand` that are of the
form
```
result = ResultBuilder.[...];
return result;
```
In other instances, the result is returned directly
```
return ResultBuilder.[...];
```
I'd change those few assign-and-immediately-return to just return the
object directly. You might then be able to delete the declaration of the
variable as well.
> Refactor FunctionCommands
> -------------------------
>
> Key: GEODE-3260
> URL: https://issues.apache.org/jira/browse/GEODE-3260
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{FunctionCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
