[
https://issues.apache.org/jira/browse/GEODE-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139208#comment-16139208
]
ASF GitHub Bot commented on GEODE-3385:
---------------------------------------
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/739
GEODE-3385: Change GetAllRequest to return list of errors.
Also:
* Rename `KeyedErrorResponse` to `KeyedError`.
* move `ErrorResponse` to `clientProtocol.proto`.
* Check for null value in `ProtobufUtilities.createEntry`.
If we find a null, we don't set the value; previously this resulted in
NPE.
Signed-off-by: Galen O'Sullivan <[email protected]>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
@WireBaron @bschuchardt @hiteshk25 @kohlmu-pivotal @pivotal-amurmann
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/galen-pivotal/geode feature/GEODE-3385
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/739.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #739
----
commit 78514a41718fb2682780bb949cf8ee4efb76224b
Author: Brian Rowe <[email protected]>
Date: 2017-08-23T21:53:06Z
GEODE-3385: Change GetAllRequest to return list of errors.
Also:
* Rename `KeyedErrorResponse` to `KeyedError`.
* move `ErrorResponse` to `clientProtocol.proto`.
* Check for null value in `ProtobufUtilities.createEntry`.
If we find a null, we don't set the value; previously this resulted in
NPE.
Signed-off-by: Galen O'Sullivan <[email protected]>
----
> Change GetAllRequest to return list of errors
> ---------------------------------------------
>
> Key: GEODE-3385
> URL: https://issues.apache.org/jira/browse/GEODE-3385
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Galen O'Sullivan
> Assignee: Galen O'Sullivan
>
> GetAllRequest currently returns a list of successful keys or an error (if
> getting any key threw an exception). We should instead return a list of
> errors, similar to PutAllRequest.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
