[
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144304#comment-16144304
]
ASF GitHub Bot commented on GEODE-3472:
---------------------------------------
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r135626288
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java
---
@@ -212,8 +211,7 @@ public static void bytesToFiles(byte[][] fileData,
String parentDirPath, boolean
}
public static boolean isValidFileName(String filePath, String extension)
{
- boolean isValid = true;
- return isValid;
+ return true;
--- End diff --
Looks unused. Must've just condensed the return from IntelliJ's inspection
window and not looked too closely at this silly method.
> Code Cleanup: remove dead code from /management.
> ------------------------------------------------
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
> Issue Type: Improvement
> Reporter: Patrick Rhomberg
> Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.
> This ticket addresses some of it, limiting scope to those files in
> `geode-core/**/management/**` to keep the eventual diff relatively small.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
