[ https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144515#comment-16144515 ]
ASF GitHub Bot commented on GEODE-3472: --------------------------------------- GitHub user PurelyApplied reopened a pull request: https://github.com/apache/geode/pull/730 GEODE-3472: Remove a great deal of commented-out code. * Correct imports in touched files * Correct several misspellings * Removed redundant modifier and specifiers * Corrected modifier orderings to adhere to style standard * Removed several //TODO comments * Removed "throws CheckedException" from methods that no longer throw the checked exception. * Minor refactorings: iterator loops to for-each, simplified conditionals, etc. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [n/a] Have you written or updated unit tests to verify your changes? [n/a: Non-functional changes.] - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PurelyApplied/geode geode-3472 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/730.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #730 ---- commit 80f44577b8f1431c14934a935f6d426f28ed0dea Author: Patrick Rhomberg <prhomb...@pivotal.io> Date: 2017-08-18T20:59:44Z GEODE-3472: Remove a great deal of commented-out code. * Correct imports in touched files * Correct several misspellings * Removed redundant modifier and specifiers * Corrected modifier orderings to adhere to style standard * Removed several //TODO comments * Removed "throws CheckedException" from methods that no longer throw the checked exception. * Minor refactorings: iterator loops to for-each, simplified conditionals, etc. commit 7a0db737bc7327adea58a5c972ad04856850c8b7 Author: Patrick Rhomberg <prhomb...@pivotal.io> Date: 2017-08-28T20:41:19Z GEODE-3472: Suggested changes in pull request. * Corrected incorrect correction of a typo in Gfsh.java * Removed dead, trivial method * Moved constant field from MBeanJMXAdapter to its use in VMStatsMonitor commit 1324ed15533dbf5fe95a81e214d81d2355f239fd Author: Patrick Rhomberg <prhomb...@pivotal.io> Date: 2017-08-28T22:10:51Z empty commit to trigger Travis. ---- > Code Cleanup: remove dead code from /management. > ------------------------------------------------ > > Key: GEODE-3472 > URL: https://issues.apache.org/jira/browse/GEODE-3472 > Project: Geode > Issue Type: Improvement > Reporter: Patrick Rhomberg > Assignee: Patrick Rhomberg > > There is a great deal of dead, commented, and unused code in the codebase. > This ticket addresses some of it, limiting scope to those files in > `geode-core/**/management/**` to keep the eventual diff relatively small. -- This message was sent by Atlassian JIRA (v6.4.14#64029)