[
https://issues.apache.org/jira/browse/GEODE-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217383#comment-16217383
]
ASF GitHub Bot commented on GEODE-1897:
---------------------------------------
dschneider-pivotal commented on a change in pull request #969: GEODE-1897: Add
eviction option to create region
URL: https://github.com/apache/geode/pull/969#discussion_r146647083
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/RegionFunctionArgs.java
##########
@@ -128,6 +132,24 @@ public void setRegionExpirationTTL(Integer timeout,
String action) {
}
}
+ public void setEvictionAttributes(String action, Integer maxMemory, Integer
maxEntryCount) {
+ if (action == null) {
+ return;
+ }
+
+ EvictionAction evictionAction = EvictionAction.parseAction(action);
+ if (maxMemory == null && maxEntryCount == null) {
+ evictionAttributes =
+ EvictionAttributes.createLRUHeapAttributes(ObjectSizer.DEFAULT,
evictionAction);
Review comment:
Users are supposed to be able to plugin their own implementation of
ObjectSizer. So you should probably support an "eviction-sizer" that takes a
class name of the ObjectSizer they want to use for heap or mem lru.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Users should be able to configure eviction through gfsh
> -------------------------------------------------------
>
> Key: GEODE-1897
> URL: https://issues.apache.org/jira/browse/GEODE-1897
> Project: Geode
> Issue Type: Sub-task
> Components: docs, gfsh
> Reporter: Swapnil Bawaskar
> Assignee: Jens Deppe
>
> While creating a region in gfsh, users should be able to configure eviction
> for that region.
> All three modes of eviction should be supported:
> 1. Eviction driven by the resource manager:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-enabled
> {noformat}
> 2. eviction driven by entry count in the region:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE
> --eviction-entry-count=1000
> {noformat}
> 3. eviction driven by bytes used:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-max-memory=100m
> {noformat}
> And also specify the eviction action as
> {noformat}
> --eviction-action=overflow-to-disk or
> --eviction-action=destroy
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
