[
https://issues.apache.org/jira/browse/GEODE-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217449#comment-16217449
]
ASF GitHub Bot commented on GEODE-1897:
---------------------------------------
pdxrunner commented on a change in pull request #969: GEODE-1897: Add eviction
option to create region
URL: https://github.com/apache/geode/pull/969#discussion_r146658739
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
##########
@@ -861,6 +861,15 @@
"region-time-to-live-expiration-action";
public static final String CREATE_REGION__REGIONEXPIRATIONTTLACTION__HELP =
"Action to be taken on a region that has exceeded the TTL expiration.";
+ public static final String CREATE_REGION__EVICTION_ACTION =
"eviction-action";
+ public static final String CREATE_REGION__EVICTION_ACTION__HELP =
+ "The eviction action to apply. Must be either 'destroy' or
'overflow-to-disk'";
+ public static final String CREATE_REGION__EVICTION_MAX_MEMORY =
"eviction-max-memory";
+ public static final String CREATE_REGION__EVICTION_MAX_MEMORY__HELP =
+ "Activates LRU eviction based on the region's memory usage specified by
this value.";
+ public static final String CREATE_REGION__EVICTION_ENTRY_COUNT =
"eviction-entry-count";
+ public static final String CREATE_REGION__EVICTION_ENTRY_COUNT__HELP =
+ "Activates LRU eviction based on the region's entry count specified by
this value.";
Review comment:
When do we stop adding to CliStrings and just define these new strings where
they're used in the Command classes? (See the email discussion thread "
[Discuss] CliStrings".)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Users should be able to configure eviction through gfsh
> -------------------------------------------------------
>
> Key: GEODE-1897
> URL: https://issues.apache.org/jira/browse/GEODE-1897
> Project: Geode
> Issue Type: Sub-task
> Components: docs, gfsh
> Reporter: Swapnil Bawaskar
> Assignee: Jens Deppe
>
> While creating a region in gfsh, users should be able to configure eviction
> for that region.
> All three modes of eviction should be supported:
> 1. Eviction driven by the resource manager:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-enabled
> {noformat}
> 2. eviction driven by entry count in the region:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE
> --eviction-entry-count=1000
> {noformat}
> 3. eviction driven by bytes used:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-max-memory=100m
> {noformat}
> And also specify the eviction action as
> {noformat}
> --eviction-action=overflow-to-disk or
> --eviction-action=destroy
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
