[
https://issues.apache.org/jira/browse/GEODE-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217823#comment-16217823
]
ASF GitHub Bot commented on GEODE-3299:
---------------------------------------
pdxrunner opened a new pull request #975: GEODE-3299: throw
CacheClosedException in FunctionContext.getCache()
URL: https://github.com/apache/geode/pull/975
Throw the exception when cache == null instead of returning the null.
Gfsh functions handle CacheClosedException, whereas
NullPointerExceptions that resulted from returning null are not.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Gfsh functions should acquire Cache from FunctionContext
> --------------------------------------------------------
>
> Key: GEODE-3299
> URL: https://issues.apache.org/jira/browse/GEODE-3299
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Kirk Lund
> Assignee: Kenneth Howe
> Fix For: 1.4.0
>
>
> Gfsh functions in geode-core
> org.apache.geode.management.internal.cli.functions currently acquire a
> reference to the Cache in several ways including from a singleton in
> CacheFactory which is prone to deadlocking. They should be modified to
> uniformly acquire the Cache from FunctionContext instead.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
