[
https://issues.apache.org/jira/browse/GEODE-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219486#comment-16219486
]
ASF subversion and git services commented on GEODE-3299:
--------------------------------------------------------
Commit 0ccf9fab8c7ccf109b91f17272c9e29f0854545e in geode's branch
refs/heads/develop from [~khowe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ccf9fa ]
GEODE-3299: throw CacheClosedException in FunctionContext.getCache() (#975)
* GEODE-3299: throw CacheClosedException when FunctionContext.getCache() == null
Gfsh functions handle CacheClosedException, whereas
NullPointerExceptions that resulted from returning null are not.
* GEODE-3299: Updates to ShowMissingDiskStoresFunction
Adjusted test in ShowMissingDiskStoresDUniotTest to expect the exception
instead of empty
results. Also removed redundant fail() assertions from the tests.
> Gfsh functions should acquire Cache from FunctionContext
> --------------------------------------------------------
>
> Key: GEODE-3299
> URL: https://issues.apache.org/jira/browse/GEODE-3299
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Kirk Lund
> Assignee: Kenneth Howe
> Fix For: 1.4.0
>
>
> Gfsh functions in geode-core
> org.apache.geode.management.internal.cli.functions currently acquire a
> reference to the Cache in several ways including from a singleton in
> CacheFactory which is prone to deadlocking. They should be modified to
> uniformly acquire the Cache from FunctionContext instead.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
