[
https://issues.apache.org/jira/browse/GEODE-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222914#comment-16222914
]
ASF GitHub Bot commented on GEODE-3894:
---------------------------------------
PivotalSarge commented on a change in pull request #985: GEODE-3894: Create
HandshakeRequest
URL: https://github.com/apache/geode/pull/985#discussion_r147524891
##########
File path: geode-protobuf/src/main/proto/connection_API.proto
##########
@@ -16,10 +16,30 @@
syntax = "proto3";
package org.apache.geode.internal.protocol.protobuf;
+enum MajorVersions {
+ INVALID_MAJOR_VERSION = 0; // Protobuf requires 0 based enum
+ CURRENT_MAJOR_VERSION = 1; // Initial message structure and handshake
protocol
+}
+enum MinorVersions {
+ INVALID_MINOR_VERSION = 0; // Protobuf requires 0 based enum
+ CURRENT_MINOR_VERSION = 1; // Protobuf implementation at initial release
+}
+
+message HandshakeRequest {
+ int32 majorVersion = 1;
+ int32 minorVersion = 2;
+}
+
+message HandshakeResponse {
+ int32 serverMajorVersion = 1;
+ int32 serverMinorVersion = 2;
+ bool handshakePassed = 3;
+}
+
message AuthenticationRequest {
map<string,string> credentials = 1;
}
message AuthenticationResponse {
bool authenticated = 1;
-}
+}
Review comment:
Maybe restore the newline?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create HandshakeRequest
> -----------------------
>
> Key: GEODE-3894
> URL: https://issues.apache.org/jira/browse/GEODE-3894
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Brian Baynes
>
> Make Handshake a HandshakeRequest that is contained in a Message the same way
> other requests are handled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
