[
https://issues.apache.org/jira/browse/GEODE-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227487#comment-16227487
]
ASF GitHub Bot commented on GEODE-3894:
---------------------------------------
galen-pivotal commented on a change in pull request #985: GEODE-3894: Create
HandshakeRequest
URL: https://github.com/apache/geode/pull/985#discussion_r148116006
##########
File path: geode-protobuf/src/main/proto/connection_API.proto
##########
@@ -16,6 +16,26 @@
syntax = "proto3";
package org.apache.geode.internal.protocol.protobuf;
+enum MajorVersions {
Review comment:
A comment explaining what these are about would be nice: that current
version will track the version that's deployed in the API. Could we write a
test for this? Do we archive proto files somewhere? (maybe a problem for down
the line)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create HandshakeRequest
> -----------------------
>
> Key: GEODE-3894
> URL: https://issues.apache.org/jira/browse/GEODE-3894
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Brian Baynes
>
> Make Handshake a HandshakeRequest that is contained in a Message the same way
> other requests are handled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
