[
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242401#comment-16242401
]
ASF GitHub Bot commented on GEODE-3136:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #144: GEODE-3136:
Convert time values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r149437438
##########
File path:
clicache/integration-test/ThinClientAppDomainFunctionExecutionTests.cs
##########
@@ -52,43 +52,45 @@ public void AddResult(TResult result)
}
public ICollection<TResult> GetResult()
{
- return GetResult(50);
+ return GetResult(TimeSpan.FromSeconds(50));
}
- public ICollection<TResult> GetResult(UInt32 timeout)
+ public ICollection<TResult> GetResult(TimeSpan timeout)
{
m_getResultCount++;
Review comment:
The counter is part of the instrumentation of this test to make sure this
method is called. It is never called by more than one thread. In fact the
endResult is not called by more than one thread either. Combined though they
modify and check the shared ready state with this method waiting on the state
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace all public API time values with std::chrono types
> ---------------------------------------------------------
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Jacob S. Barrett
> Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public
> API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
