[
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242421#comment-16242421
]
ASF GitHub Bot commented on GEODE-3136:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #144: GEODE-3136:
Convert time values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r149440512
##########
File path: cppcache/include/geode/RegionFactory.hpp
##########
@@ -249,14 +253,6 @@ class CPPCACHE_EXPORT RegionFactory {
*/
RegionFactory& setConcurrencyChecksEnabled(bool enable);
- /**
- * Sets time out for tombstones
- * @since 7.0
- * @param tombstoneTimeoutInMSec tombstone timeout in milli second
- * @return a reference to <code>this</code>
- */
- RegionFactory& setTombstoneTimeout(uint32_t tombstoneTimeoutInMSec);
Review comment:
I think I found that it was never implemented in any file and since nothing
tested it the compiler and linker never complained it was unimplemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace all public API time values with std::chrono types
> ---------------------------------------------------------
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Jacob S. Barrett
> Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public
> API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
