[
https://issues.apache.org/jira/browse/GEODE-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254171#comment-16254171
]
ASF GitHub Bot commented on GEODE-3341:
---------------------------------------
jinmeiliao commented on a change in pull request #1062: GEODE-3341: Convert
DiskStoreCommandsDUnitTest to use gfsh rules
URL: https://github.com/apache/geode/pull/1062#discussion_r151248107
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/CommandResult.java
##########
@@ -605,6 +609,28 @@ public GfJsonObject getContent() {
return gfJsonObject.getJSONObject(ResultData.RESULT_CONTENT);
}
+ /**
+ * The intent is that this method should be able to handle both ResultData
as well as
+ * CompositeResultData
+ *
+ * @return the extracted GfJsonObject table
+ */
+ public GfJsonObject getTableContent() {
Review comment:
shouldn't this method takes in a sectionNumber as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor DiskStoreCommandsDUnitTest to use test rules
> -----------------------------------------------------
>
> Key: GEODE-3341
> URL: https://issues.apache.org/jira/browse/GEODE-3341
> Project: Geode
> Issue Type: Sub-task
> Components: tests
> Affects Versions: 1.2.0
> Reporter: Emily Yeh
> Assignee: Jens Deppe
>
> {{DiskStoreCommandsDUnitTest}} is using {{CliCommandTestBase}}, which is a
> deprecated class. It should be refactored to use more current test rules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
