[
https://issues.apache.org/jira/browse/GEODE-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254649#comment-16254649
]
ASF GitHub Bot commented on GEODE-3341:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #1062: GEODE-3341: Convert
DiskStoreCommandsDUnitTest to use gfsh rules
URL: https://github.com/apache/geode/pull/1062#discussion_r151307820
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DestroyDiskStoreFunction.java
##########
@@ -80,7 +80,6 @@ public void execute(FunctionContext context) {
} catch (VirtualMachineError e) {
Review comment:
I'm going to do that in the next PR which adds the `--if-exists` option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor DiskStoreCommandsDUnitTest to use test rules
> -----------------------------------------------------
>
> Key: GEODE-3341
> URL: https://issues.apache.org/jira/browse/GEODE-3341
> Project: Geode
> Issue Type: Sub-task
> Components: tests
> Affects Versions: 1.2.0
> Reporter: Emily Yeh
> Assignee: Jens Deppe
>
> {{DiskStoreCommandsDUnitTest}} is using {{CliCommandTestBase}}, which is a
> deprecated class. It should be refactored to use more current test rules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
