[
https://issues.apache.org/jira/browse/GEODE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254484#comment-16254484
]
ASF GitHub Bot commented on GEODE-3624:
---------------------------------------
mhansonp commented on a change in pull request #152: GEODE-3624: Update C++
client exceptions to implement std::exception interface
URL: https://github.com/apache/geode-native/pull/152#discussion_r151285007
##########
File path: cppcache/src/ExceptionTypes.cpp
##########
@@ -39,294 +40,338 @@ void GfErrTypeThrowException(const char* str, GfErrType
err) {
}
switch (err) {
case GF_NOTCON: {
- NotConnectedException ex(
- str, (exMsg != nullptr ? exMsg : ": not connected to Geode"));
+ std::stringstream ss;
+ ss << str << (exMsg != nullptr ? exMsg : ": not connected to Geode");
+ NotConnectedException ex(ss.str());
Review comment:
Nitpick here, but I think you can use a string and append the values you
want here. I think it would be faster, though not by a whole lot. Why go that
way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update exceptions to more closely match standard exception interface
> --------------------------------------------------------------------
>
> Key: GEODE-3624
> URL: https://issues.apache.org/jira/browse/GEODE-3624
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: David Kimura
>
> Native client library should follow standard exception interface for any
> thrown exceptions. This means one less custom interface that a customer or
> developer needs to understand.
> {noformat}
> namespace apache {
> namespace geode {
> namespace client {
> class Exception : public std::exception {...};
> class IllegalArgumentException : public Exception {...};
> class TransactionException : public Exception {...};
> class RollbackException : public TransactionException {...};
> // NO - class IllegalArgumentException : public Exception, public
> std::invalid_argument {...};
> // NO - class IllegalArgumentException : public std::invalid_argument {...};
> // NO - class IllegalArgumentException : public Exception, public
> TransactionException {...};
> }
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
