[
https://issues.apache.org/jira/browse/GEODE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255647#comment-16255647
]
ASF GitHub Bot commented on GEODE-3624:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #152: GEODE-3624: Update
C++ client exceptions to implement std::exception interface
URL: https://github.com/apache/geode-native/pull/152#discussion_r151483255
##########
File path: cppcache/include/geode/Exception.hpp
##########
@@ -52,9 +52,9 @@ class CPPCACHE_EXPORT Exception : public std::exception {
/** Creates an exception.
* @param msg1 message pointer, this is copied into the exception.
**/
- Exception(const char* msg1);
+ explicit Exception(const char* msg1);
Review comment:
I think it is only really necessary when the first arg is a ref to avoid a
conversation copy construct. Though it probably doesn't hurt here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update exceptions to more closely match standard exception interface
> --------------------------------------------------------------------
>
> Key: GEODE-3624
> URL: https://issues.apache.org/jira/browse/GEODE-3624
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: David Kimura
>
> Native client library should follow standard exception interface for any
> thrown exceptions. This means one less custom interface that a customer or
> developer needs to understand.
> {noformat}
> namespace apache {
> namespace geode {
> namespace client {
> class Exception : public std::exception {...};
> class IllegalArgumentException : public Exception {...};
> class TransactionException : public Exception {...};
> class RollbackException : public TransactionException {...};
> // NO - class IllegalArgumentException : public Exception, public
> std::invalid_argument {...};
> // NO - class IllegalArgumentException : public std::invalid_argument {...};
> // NO - class IllegalArgumentException : public Exception, public
> TransactionException {...};
> }
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
