[
https://issues.apache.org/jira/browse/GEODE-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271303#comment-16271303
]
ASF GitHub Bot commented on GEODE-3288:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #160: GEODE-3288:
Converts char* to std::string on public API.
URL: https://github.com/apache/geode-native/pull/160#discussion_r153875080
##########
File path: cppcache/include/geode/CacheableBuiltins.hpp
##########
@@ -40,12 +40,6 @@ namespace client {
template <typename Target, int8_t TYPEID>
class CacheableArrayType;
-/** sprintf implementation. */
-extern int gf_sprintf(char* buffer, const char* fmt, ...);
-
-/** snprintf implementation. */
-extern int gf_snprintf(char* buffer, int32_t maxLength, const char* fmt, ...);
-
/** Template CacheableKey class for primitive types. */
template <typename TObj, int8_t TYPEID, const char* TYPENAME,
const char* SPRINTFSYM, int32_t STRSIZE>
Review comment:
I don't think we can, `std::string` is not `constexpr`. C++17 adds
`std::string_view` which is `constexpr`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace char* with std::string
> ------------------------------
>
> Key: GEODE-3288
> URL: https://issues.apache.org/jira/browse/GEODE-3288
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
>
> In all public API headers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
