[
https://issues.apache.org/jira/browse/GEODE-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271312#comment-16271312
]
ASF GitHub Bot commented on GEODE-3288:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #160: GEODE-3288:
Converts char* to std::string on public API.
URL: https://github.com/apache/geode-native/pull/160#discussion_r153875736
##########
File path: cppcache/integration-test/TallyListener.hpp
##########
@@ -122,8 +122,8 @@ class TallyListener : public CacheListener {
if (m_callbackArg != nullptr) {
auto callbkArg =
std::dynamic_pointer_cast<CacheableKey>(event.getCallbackArgument());
- if (strcmp(m_callbackArg->toString()->asChar(),
- callbkArg->toString()->asChar()) == 0) {
+ if (strcmp(m_callbackArg->toString().c_str(),
+ callbkArg->toString().c_str()) == 0) {
Review comment:
Nope! Was using global search and replace on internal code, especially test,
to just get the API cleaned up. We can optimize internals later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace char* with std::string
> ------------------------------
>
> Key: GEODE-3288
> URL: https://issues.apache.org/jira/browse/GEODE-3288
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
>
> In all public API headers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
