[
https://issues.apache.org/jira/browse/GEODE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281210#comment-16281210
]
ASF GitHub Bot commented on GEODE-4059:
---------------------------------------
WireBaron opened a new pull request #1137: GEODE-4059: Changing protobuf
handshake to not need communication mod…
URL: https://github.com/apache/geode/pull/1137
…e bytes
- Moved handshake proto messages into top level handshake.proto
- Changed protobuf communication mode to match leading byte of handshake
- Updated handshake handler and tests to handle changes
- Modified locator to accept protobuf communication mode in lieu of gossip
Signed-off-by: Galen O'Sullivan <[email protected]>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Stop using magic bytes in protobuf connection establishment
> -----------------------------------------------------------
>
> Key: GEODE-4059
> URL: https://issues.apache.org/jira/browse/GEODE-4059
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Brian Rowe
>
> When connection to the server, the client currently uses some magic bytes to
> identify the protocol being used. This is non-intuitive and problematic for
> client developers, and should not be necessary if we make clever use of a
> magic protobuf connection establishing message. This should also serve as
> our handshake.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
