[
https://issues.apache.org/jira/browse/GEODE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283917#comment-16283917
]
ASF subversion and git services commented on GEODE-4059:
--------------------------------------------------------
Commit 15bb387bd086447ec55b264966819e70d40f608d in geode's branch
refs/heads/develop from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=15bb387 ]
GEODE-4059: Changing protobuf handshake to not need communication mode bytes
This closes pull request #1137
Squashed commit of the following:
commit d9f5144cd7f7ddcf42eb7eb5febed531cbf67362
Merge: 6fa9bf6c8 8fd707201
Author: Bruce Schuchardt <[email protected]>
Date: Fri Dec 8 09:34:55 2017 -0800
Merge branch 'feature/GEODE-4059' of https://github.com/WireBaron/geode
into WireBaron-feature/GEODE-4059
commit 8fd707201f0e02b1fdf81c1596f93d3fd9ccb0cf
Author: Brian Rowe <[email protected]>
Date: Thu Dec 7 14:53:28 2017 -0800
Removing extra handshake from a unit test.
Signed-off-by: Galen O'Sullivan <[email protected]>
commit 7d07c6f5163d99b92a12ca856a1b397fda6e0eb4
Author: Galen O'Sullivan <[email protected]>
Date: Wed Dec 6 16:20:25 2017 -0800
GEODE-4059: Changing protobuf handshake to not need communication mode bytes
- Moved handshake proto messages into top level handshake.proto
- Changed protobuf communication mode to match leading byte of handshake
- Updated handshake handler and tests to handle changes
- Modified locator to accept protobuf communication mode in lieu of gossip
Signed-off-by: Brian Rowe <[email protected]>
> Stop using magic bytes in protobuf connection establishment
> -----------------------------------------------------------
>
> Key: GEODE-4059
> URL: https://issues.apache.org/jira/browse/GEODE-4059
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Brian Rowe
>
> When connection to the server, the client currently uses some magic bytes to
> identify the protocol being used. This is non-intuitive and problematic for
> client developers, and should not be necessary if we make clever use of a
> magic protobuf connection establishing message. This should also serve as
> our handshake.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
