[
https://issues.apache.org/jira/browse/GEODE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282104#comment-16282104
]
ASF GitHub Bot commented on GEODE-4061:
---------------------------------------
bschuchardt commented on a change in pull request #1138: Feature/GEODE-4061 :
Adding coordinator in list member command output
URL: https://github.com/apache/geode/pull/1138#discussion_r155571206
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
##########
@@ -74,4 +80,18 @@ public Result listMember(@CliOption(key =
{CliStrings.GROUP}, unspecifiedDefault
}
return result;
}
+
+ private String getCoordinator() {
+ String result = "unknown";
+ InternalDistributedSystem ids =
InternalDistributedSystem.getConnectedInstance();
+ if ((ids != null) && (ids.isConnected())) {
+ MembershipManager mmgr =
ids.getDistributionManager().getMembershipManager();
+ DistributedMember coord = ((GMSMembershipManager) mmgr).getCoordinator();
Review comment:
This code shouldn't refer to GMSMembershipManager. Why don't you add a
getCoordinator() method to NetView or to the MembershipManager interface?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Adding coordinator in list member command output
> ------------------------------------------------
>
> Key: GEODE-4061
> URL: https://issues.apache.org/jira/browse/GEODE-4061
> Project: Geode
> Issue Type: Bug
> Components: core
> Reporter: dinesh ak
>
> no way to find out the coordinator apart from log messages.
> i have added coordinator in list member command output.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
