[
https://issues.apache.org/jira/browse/GEODE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295447#comment-16295447
]
ASF GitHub Bot commented on GEODE-4061:
---------------------------------------
pdxrunner closed pull request #1138: Feature/GEODE-4061 : Adding coordinator in
list member command output
URL: https://github.com/apache/geode/pull/1138
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
index f9e5544aef..1a787f383d 100644
---
a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
+++
b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
@@ -314,4 +314,9 @@ public boolean waitForDeparture(DistributedMember mbr)
*/
public void releaseQuorumChecker(QuorumChecker checker);
+ /**
+ * return the coordinator for the view.
+ */
+ public DistributedMember getCoordinator();
+
}
diff --git
a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
index 49336962f5..9232c6e04d 100644
---
a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
+++
b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
@@ -1401,6 +1401,7 @@ private boolean isJoining() {
*
* @return the current membership view coordinator
*/
+ @Override
public DistributedMember getCoordinator() {
latestViewReadLock.lock();
try {
diff --git
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
index 34207cdbb9..6b25800082 100644
---
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
+++
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
@@ -22,6 +22,8 @@
import org.springframework.shell.core.annotation.CliOption;
import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.distributed.internal.membership.MembershipManager;
import org.apache.geode.internal.cache.InternalCache;
import org.apache.geode.management.cli.CliMetaData;
import org.apache.geode.management.cli.ConverterHint;
@@ -59,7 +61,11 @@ public Result listMember(@CliOption(key =
{CliStrings.GROUP}, unspecifiedDefault
if (memberSet.isEmpty()) {
result =
ResultBuilder.createInfoResult(CliStrings.LIST_MEMBER__MSG__NO_MEMBER_FOUND);
} else {
+
TabularResultData resultData = ResultBuilder.createTabularResultData();
+ final String coordinatorMember = getCoordinator();
+ resultData.accumulate("Name", "Coordinator:");
+ resultData.accumulate("Id", coordinatorMember);
for (DistributedMember member : memberSet) {
resultData.accumulate("Name", member.getName());
resultData.accumulate("Id", member.getId());
@@ -74,4 +80,18 @@ public Result listMember(@CliOption(key =
{CliStrings.GROUP}, unspecifiedDefault
}
return result;
}
+
+ private String getCoordinator() {
+ String result = "unknown";
+ InternalDistributedSystem ids =
InternalDistributedSystem.getConnectedInstance();
+ if ((ids != null) && (ids.isConnected())) {
+ MembershipManager mmgr =
ids.getDistributionManager().getMembershipManager();
+ DistributedMember coord = mmgr.getCoordinator();
+ if (coord != null) {
+ result = coord.toString();
+ }
+ }
+
+ return result;
+ }
}
diff --git
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java
index 3ad80a91d0..c95fcfa9ba 100644
---
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java
+++
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java
@@ -67,6 +67,7 @@ public void listAllMembers() throws Exception {
assertThat(output).contains("server-1");
assertThat(output).contains("server-2");
assertThat(output).contains("server-3");
+ assertThat(output).contains("Coordinator");
}
@Test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Adding coordinator in list member command output
> ------------------------------------------------
>
> Key: GEODE-4061
> URL: https://issues.apache.org/jira/browse/GEODE-4061
> Project: Geode
> Issue Type: Bug
> Components: docs, messaging
> Reporter: dinesh ak
>
> no way to find out the coordinator apart from log messages.
> i have added coordinator in list member command output.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
