[
https://issues.apache.org/jira/browse/GEODE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293059#comment-16293059
]
ASF GitHub Bot commented on GEODE-4090:
---------------------------------------
WireBaron opened a new pull request #1172: GEODE-4090: Add ErrorCode mirroring
ProtocolErrorCode enum into protobuf
URL: https://github.com/apache/geode/pull/1172
also added a test to assert the protobuf error codes match the protocol
error codes
@upthewaterspout @galen-pivotal @PivotalSarge @bschuchardt
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use an enum for Error.errorCode, rather than an int32
> -----------------------------------------------------
>
> Key: GEODE-4090
> URL: https://issues.apache.org/jira/browse/GEODE-4090
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Brian Baynes
>
> Currently, the error codes in the new protocol are returned as integers and
> are documented on the wiki in
> https://cwiki.apache.org/confluence/display/GEODE/Error+Codes and in the code
> in ProtocolErrorCodes.
> Protobuf has support for enums, we should use an enum instead of an int32 for
> the error code so that the list of possible errors is part of the protobuf
> specification. This will make it clearer to the user what each error code
> means and will prevent them from having to put the constants in their own
> code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
