[
https://issues.apache.org/jira/browse/GEODE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293484#comment-16293484
]
ASF subversion and git services commented on GEODE-4090:
--------------------------------------------------------
Commit 19b81995a0666ce7e6898e386684fcba4e291cf0 in geode's branch
refs/heads/develop from [~WireBaron]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=19b8199 ]
GEODE-4090: Add ErrorCode mirroring ProtocolErrorCode enum into protobuf
* GEODE-4090: Add ErrorCode mirroring ProtocolErrorCode enum into protobuf
also added a test to assert the protobuf error codes match the protocol
error codes
> Use an enum for Error.errorCode, rather than an int32
> -----------------------------------------------------
>
> Key: GEODE-4090
> URL: https://issues.apache.org/jira/browse/GEODE-4090
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Brian Baynes
>
> Currently, the error codes in the new protocol are returned as integers and
> are documented on the wiki in
> https://cwiki.apache.org/confluence/display/GEODE/Error+Codes and in the code
> in ProtocolErrorCodes.
> Protobuf has support for enums, we should use an enum instead of an int32 for
> the error code so that the list of possible errors is part of the protobuf
> specification. This will make it clearer to the user what each error code
> means and will prevent them from having to put the constants in their own
> code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
