[ 
https://issues.apache.org/jira/browse/GEODE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301567#comment-16301567
 ] 

ASF GitHub Bot commented on GEODE-4143:
---------------------------------------

dgkimura commented on a change in pull request #172: GEODE-4143: Improves 
integration test stability.
URL: https://github.com/apache/geode-native/pull/172#discussion_r158509947
 
 

 ##########
 File path: clicache/integration-test/CacheHelperN.cs
 ##########
 @@ -1990,7 +1990,7 @@ static int getLocatorPort(int num)
         {
           extraLocatorArgs = locatorPort;
         }
-        string locatorArgs = LocatorStartArgs + " --name=" + serverName + 
startDir + extraLocatorArgs;
+        string locatorArgs = LocatorStartArgs + " --name=" + serverName + 
startDir + extraLocatorArgs + " --http-service-port=0";
 
 Review comment:
   How did this improve stability?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Improve test stability
> ----------------------
>
>                 Key: GEODE-4143
>                 URL: https://issues.apache.org/jira/browse/GEODE-4143
>             Project: Geode
>          Issue Type: Test
>          Components: native client
>            Reporter: Jacob S. Barrett
>            Assignee: Jacob S. Barrett
>
> Remove explicitly output logging at the test level and leverage the test 
> runner. This removes tee which tends to hang on windows, causing the test to 
> hang. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to