[
https://issues.apache.org/jira/browse/GEODE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301634#comment-16301634
]
ASF GitHub Bot commented on GEODE-4143:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #172: GEODE-4143:
Improves integration test stability.
URL: https://github.com/apache/geode-native/pull/172#discussion_r158521672
##########
File path: cppcache/integration-test/CacheHelper.cpp
##########
@@ -1848,16 +1851,17 @@ int CacheHelper::getRandomAvailablePort() {
}
std::string CacheHelper::unitTestOutputFile() {
- char currWDPath[512];
Review comment:
We could use boost::filesystem here. I just wanted to make it less nasty
than it was to move forward since this is framework code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve test stability
> ----------------------
>
> Key: GEODE-4143
> URL: https://issues.apache.org/jira/browse/GEODE-4143
> Project: Geode
> Issue Type: Test
> Components: native client
> Reporter: Jacob S. Barrett
> Assignee: Jacob S. Barrett
>
> Remove explicitly output logging at the test level and leverage the test
> runner. This removes tee which tends to hang on windows, causing the test to
> hang.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
