[
https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312597#comment-16312597
]
Cyrille Artho commented on GEODE-3584:
--------------------------------------
Is it possible to push this to the shared repository under a new branch
feature/GEODE-3584?
There is still work left to make all the test code compile, due to the need to
use extra typecasts when javac cannot figure out which way AbstractLauncher or
its builder is subclassed.
The patch is now quite large, about 3.5 K lines (incl. context, headers). I
will try to merge "develop" every now and then, hopefully without conflicts...
> Refactor ServerLauncher and LocatorLauncher to eliminate code duplication
> -------------------------------------------------------------------------
>
> Key: GEODE-3584
> URL: https://issues.apache.org/jira/browse/GEODE-3584
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Affects Versions: 1.2.0
> Reporter: Kenneth Howe
> Attachments: GEODE-3584-WIP
>
>
> There is some duplication of code in the Launcher classes that can be
> eliminated. Both classes have methods such as getBindAddress (called
> getServerBindAddress in ServerLauncher) that could be hoisted into
> AbstractLauncher class that they both extend. The same goes for the inner
> State classes of the Launchers; they have methods that could be moved to
> AbstractLauncher.ServiceState.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
